fyb/calcurse-edge
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

calcurse-caldav: remove authorization data from logs

Browse Source 
The Authorization header contains the Base64-encoded user name and
password. Remove this information from debug logs, unless the user
explicitly requests to keep them by using the --debug-raw flag.

Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
This commit is contained in:
Lukas Fleischer 2018-05-23 17:58:25 +02:00
parent 912124bcdc
commit fda8c1a7e2
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/caldav/calcurse-caldav.py
View File

@ -189,7 +189,10 @@ def remote_query(conn, cmd, path, additional_headers, body):
if debug: if debug:
print("> {} {}".format(cmd, path)) print("> {} {}".format(cmd, path))
print("> Headers: " + repr(headers)) headers_sanitized = headers
if not debug_raw:
headers_sanitized.pop('Authorization', None)
print("> Headers: " + repr(headers_sanitized))
if body: if body:
for line in body.splitlines(): for line in body.splitlines():
print("> " + line) print("> " + line)
@ -504,6 +507,8 @@ parser.add_argument('-v', '--verbose', action='store_true', dest='verbose',
help='print status messages to stdout') help='print status messages to stdout')
parser.add_argument('--debug', action='store_true', dest='debug', parser.add_argument('--debug', action='store_true', dest='debug',
default=False, help='print debug messages to stdout') default=False, help='print debug messages to stdout')
parser.add_argument('--debug-raw', action='store_true', dest='debug_raw',
default=False, help='do not sanitize debug messages')
args = parser.parse_args() args = parser.parse_args()
init = args.init is not None init = args.init is not None
@ -514,6 +519,7 @@ hookdir = args.hookdir
authcode = args.authcode authcode = args.authcode
verbose = args.verbose verbose = args.verbose
debug = args.debug debug = args.debug
debug_raw = args.debug_raw
# Read environment variables # Read environment variables
password = os.getenv('CALCURSE_CALDAV_PASSWORD') password = os.getenv('CALCURSE_CALDAV_PASSWORD')