fyb/calcurse-edge
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/io.c: Use fork_exec() instead of system()

Browse Source 
Speeds up execution, prevents failures when pager or log file contains
spaces, fixes a warning seen with "-Wunused-result".

Signed-off-by: Lukas Fleischer <calcurse@cryptocrack.de>
This commit is contained in:
Lukas Fleischer 2012-02-18 14:59:15 +01:00
parent fb58416f45
commit 9a8ea7ff91
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/io.c
View File

@ -1230,10 +1230,11 @@ io_log_display (struct io_file *log, char *msg, char *pager)
ans = fgetc (stdin); ans = fgetc (stdin);
if (ans == 'y') if (ans == 'y')
{ {
char cmd[BUFSIZ]; char *arg[] = { pager, log->name, NULL };
int pid;
snprintf (cmd, BUFSIZ, "%s %s", pager, log->name); if ((pid = fork_exec (NULL, NULL, pager, arg)))
system (cmd); child_wait (NULL, NULL, pid);
} }
} }
else else