fyb/calcurse-edge
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "calcurse-caldav: Add --password command line argument"

Browse Source 
This reverts commit efd76a0d995292e48f5466fccada4901618f7d97.

Passing passwords as command line arguments is not a good idea, since
they may appear in process listings which are potentially visible to
other users logged into the system.

Signed-off-by: Lukas Fleischer <lfleischer@calcurse.org>
This commit is contained in:
Lukas Fleischer 2017-11-08 21:53:46 +01:00
parent b96e175192
commit 5b94be2246
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/caldav/calcurse-caldav.py
View File

@ -489,9 +489,6 @@ parser.add_argument('--syncdb', action='store', dest='syncdbfn',
parser.add_argument('--hookdir', action='store', dest='hookdir', parser.add_argument('--hookdir', action='store', dest='hookdir',
default=hookdir, default=hookdir,
help='path to the calcurse-caldav hooks directory') help='path to the calcurse-caldav hooks directory')
parser.add_argument('--password', action='store', dest='password',
default=None,
help='password for basic authentication')
parser.add_argument('--authcode', action='store', dest='authcode', parser.add_argument('--authcode', action='store', dest='authcode',
default=None, default=None,
help='auth code for OAuth2 authentication') help='auth code for OAuth2 authentication')
@ -507,7 +504,6 @@ configfn = args.configfn
lockfn = args.lockfn lockfn = args.lockfn
syncdbfn = args.syncdbfn syncdbfn = args.syncdbfn
hookdir = args.hookdir hookdir = args.hookdir
password = args.password
authcode = args.authcode authcode = args.authcode
verbose = args.verbose verbose = args.verbose
debug = args.debug debug = args.debug
@ -567,8 +563,10 @@ if config.has_option('Auth', 'UserName'):
else: else:
username = None username = None
if config.has_option('Auth', 'Password') and not password: if config.has_option('Auth', 'Password'):
password = config.get('Auth', 'Password') password = config.get('Auth', 'Password')
else:
password = None
if config.has_section('CustomHeaders'): if config.has_section('CustomHeaders'):
custom_headers = dict(config.items('CustomHeaders')) custom_headers = dict(config.items('CustomHeaders'))